Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-5434 - meta data endpoint #4488

Merged
merged 23 commits into from
Nov 3, 2023
Merged

Conversation

hoeppner-dataport
Copy link
Contributor

@hoeppner-dataport hoeppner-dataport commented Oct 20, 2023

Description

Implement module and endpoint that extracts needed meta data from external pages in order to allow previews (title, description, image) of links to external pages.

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-5434
https://github.com/hpi-schul-cloud/nuxt-client/pull/2876z

Changes

Datasecurity

  • using a backend endpoint to request this meta data we prevent that data of users (cookies) is shared with external sites

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

Copy link

sonarqubecloud bot commented Nov 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@hoeppner-dataport hoeppner-dataport merged commit a3fd43f into main Nov 3, 2023
47 checks passed
@hoeppner-dataport hoeppner-dataport deleted the BC-5434-meta-data-endpoint branch November 3, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants